From b7ad285a11a0c9dd4603a1be5348d5f167778add Mon Sep 17 00:00:00 2001
From: John <j@soft.fish>
Date: Wed, 24 Jul 2024 14:29:27 -0500
Subject: [PATCH] cl-typeck: give Handle accessors for useful attributes

---
 compiler/cl-typeck/examples/typeck.rs | 36 +++++++++++----------------
 compiler/cl-typeck/src/handle.rs      | 30 ++++++++++++++++++++++
 2 files changed, 44 insertions(+), 22 deletions(-)

diff --git a/compiler/cl-typeck/examples/typeck.rs b/compiler/cl-typeck/examples/typeck.rs
index 5629f78..6367d95 100644
--- a/compiler/cl-typeck/examples/typeck.rs
+++ b/compiler/cl-typeck/examples/typeck.rs
@@ -5,10 +5,8 @@ use cl_ast::{
 use cl_lexer::Lexer;
 use cl_parser::{inliner::ModuleInliner, Parser};
 use cl_typeck::{
-    definition::Def,
     handle::Handle,
     name_collector::NameCollector,
-    node::{Node, NodeSource},
     project::Project,
     type_resolver::resolve,
 };
@@ -158,7 +156,7 @@ fn get_by_id(prj: &mut Project) -> Result<(), RlError> {
             Err("No results.")?
         }
         if let Some(t) = ty {
-            println!("Result in type namespace: {}", t.id());
+            println!("Result: {}", t.id());
             pretty_handle(t)?;
         }
         if let Some(v) = value {
@@ -180,40 +178,34 @@ fn resolve_all(prj: &mut Project) -> Result<(), Box<dyn Error>> {
 }
 
 fn list_types(prj: &mut Project) {
-    println!("     name\x1b[30G  type");
+    println!("     name            | type");
     for (idx, key) in prj.pool.keys().enumerate() {
-        let Def { node: Node { vis, kind: source, .. }, .. } = &prj[key];
-        let name = match source.as_ref().map(NodeSource::name) {
-            Some(Some(name)) => name,
-            _ => "".into(),
-        };
-        print!(
-            "{idx:3}: {vis}{name}\x1b[30G = {}",
-            key.handle_unchecked(prj)
-        );
-        println!();
+        let handle = key.handle_unchecked(prj);
+        let vis = handle.vis().unwrap_or_default();
+        let name = handle.name().unwrap_or("".into());
+        println!("{idx:3}: {name:16}| {vis}{handle}");
     }
 }
 
 fn pretty_handle(handle: Handle) -> Result<(), std::io::Error> {
     use std::io::Write;
     let mut stdout = std::io::stdout().lock();
-    let Some(Def { module, node: Node { vis, .. }, .. }) = handle.get() else {
+    let Some(vis) = handle.vis() else {
         return writeln!(stdout, "Invalid handle: {handle}");
     };
-    writeln!(stdout, "{C_LISTING}{vis}{handle}\x1b[0m: {}", handle.id())?;
-    if let Some(parent) = module.parent {
-        writeln!(stdout, "{C_LISTING}Parent\x1b[0m: {}", handle.with(parent))?;
+    writeln!(stdout, "{C_LISTING}{}\x1b[0m: {vis}{handle}", handle.id())?;
+    if let Some(parent) = handle.parent() {
+        writeln!(stdout, "{C_LISTING}Parent\x1b[0m: {parent}")?;
     }
-    if !module.types.is_empty() {
+    if let Some(types) = handle.types() {
         writeln!(stdout, "{C_LISTING}Types:\x1b[0m")?;
-        for (name, def) in &module.types {
+        for (name, def) in types {
             writeln!(stdout, "- {C_LISTING}{name}\x1b[0m: {}", handle.with(*def))?
         }
     }
-    if !module.values.is_empty() {
+    if let Some(values) = handle.values() {
         writeln!(stdout, "{C_LISTING}Values:\x1b[0m")?;
-        for (name, def) in &module.values {
+        for (name, def) in values {
             writeln!(stdout, "- {C_LISTING}{name}\x1b[0m: {}", handle.with(*def))?
         }
     }
diff --git a/compiler/cl-typeck/src/handle.rs b/compiler/cl-typeck/src/handle.rs
index c4b6fe3..0546f44 100644
--- a/compiler/cl-typeck/src/handle.rs
+++ b/compiler/cl-typeck/src/handle.rs
@@ -72,6 +72,36 @@ impl<'p, 'c> Handle<'p, 'c> {
     }
 }
 
+mod emulate_def {
+    use super::*;
+    use cl_ast::{Sym, Visibility};
+    use cl_structures::span::Span;
+    use std::collections::HashMap;
+
+    impl<'p, 'c> Handle<'p, 'c> {
+        pub fn name(self) -> Option<Sym> {
+            self.get()?.name()
+        }
+        pub fn vis(self) -> Option<Visibility> {
+            Some(self.get()?.node.vis)
+        }
+        pub fn span(self) -> Option<Span> {
+            Some(*self.get()?.node.span)
+        }
+        pub fn parent(self) -> Option<Self> {
+            self.get()?.module.parent.map(|id| self.with(id))
+        }
+        pub fn types(self) -> Option<&'p HashMap<Sym, DefID>> {
+            let types = &self.get()?.module.types;
+            (!types.is_empty()).then_some(types)
+        }
+        pub fn values(self) -> Option<&'p HashMap<Sym, DefID>> {
+            let values = &self.get()?.module.values;
+            (!values.is_empty()).then_some(values)
+        }
+    }
+}
+
 mod display {
     use super::*;
     use crate::{definition::*, format_utils::*};