j/Conlang
1
1
Fork 0
Code Issues 5 Pull Requests Packages Projects 2 Releases Wiki Activity

cl-structures/stack: only drop if T needs drop

Browse Source
This commit is contained in:
John 2024-04-27 21:08:09 -05:00
parent e7c5a02afa
commit a8ef989084
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
compiler/cl-structures/src/stack.rs
View File

@ -164,7 +164,9 @@ unsafe impl<#[may_dangle] T, const N: usize> Drop for Stack<T, N> {
#[inline] #[inline]
fn drop(&mut self) { fn drop(&mut self) {
// Safety: We have ensured that all elements in the list are // Safety: We have ensured that all elements in the list are
unsafe { core::ptr::drop_in_place(self.as_mut_slice()) }; if std::mem::needs_drop::<T>() {
unsafe { core::ptr::drop_in_place(self.as_mut_slice()) };
}
} }
} }
@ -617,7 +619,6 @@ mod tests {
assert_eq!(std::mem::size_of::<usize>(), std::mem::size_of_val(&v)) assert_eq!(std::mem::size_of::<usize>(), std::mem::size_of_val(&v))
} }
#[test] #[test]
#[cfg_attr(debug_assertions, ignore = "calls ().drop() usize::MAX times")]
fn from_usize_max_zst_array() { fn from_usize_max_zst_array() {
let mut v = Stack::from([(); usize::MAX]); let mut v = Stack::from([(); usize::MAX]);
assert_eq!(v.len(), usize::MAX); assert_eq!(v.len(), usize::MAX);